Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sample Runbook code to support multiple App GWs #3645

Conversation

SvenAelterman
Copy link
Collaborator

@SvenAelterman SvenAelterman commented Aug 2, 2023

Resolves #3643, #3644

What is being addressed

Enhance sample PowerShell Runbook scripts to automate stopping and (new) starting TRE resources.

How is this addressed

  • Support for multiple Application Gateways
  • New sample script to create a start Runbook
  • Linting PowerShell
  • Enhance/expand comments
  • Fix typos

Adding PowerShell 7.2 as a runbook option
Linting PowerShell
Adding/expanding comments
@SvenAelterman SvenAelterman added the documentation Improvements or additions to documentation label Aug 2, 2023
@SvenAelterman SvenAelterman changed the title 3643 automation runbook script to stop tre resources fails if certs application gateway exists Fix sample Runbook code to support multiple App GWs Aug 2, 2023
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit cd41c87.

♻️ This comment has been updated with latest results.

@SvenAelterman SvenAelterman marked this pull request as draft August 2, 2023 01:40
@SvenAelterman SvenAelterman marked this pull request as ready for review August 2, 2023 02:29
@marrobi
Copy link
Member

marrobi commented Aug 2, 2023

/test-force-approve

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit c0e076a)

(in response to this comment from @marrobi)

Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - haven't tested, but trust you have?

Thanks.

@SvenAelterman
Copy link
Collaborator Author

LGTM - haven't tested, but trust you have?

Yes, actively using both in Automation.

@SvenAelterman SvenAelterman enabled auto-merge (squash) August 2, 2023 11:32
@marrobi
Copy link
Member

marrobi commented Aug 2, 2023

/test-force-approve

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit cd41c87)

(in response to this comment from @marrobi)

@SvenAelterman SvenAelterman merged commit 10d6d15 into microsoft:main Aug 2, 2023
10 checks passed
@SvenAelterman SvenAelterman deleted the 3643-automation-runbook-script-to-stop-tre-resources-fails-if-certs-application-gateway-exists branch August 2, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automation runbook script to stop TRE resources fails if certs Application Gateway exists
2 participants